Change in vdsm[master]: tests: Remove dead code

danken at redhat.com danken at redhat.com
Sun Sep 14 21:44:28 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: Remove dead code
......................................................................


tests: Remove dead code

Commit 36a81b5aef added the legacy getServices interface, which is not
part of the ModuleConfigurator. The new services property is inherited
from the super class, so there is no need to implement it.

Change-Id: I32c23258e90ff8551131c2703ebd2c1238d46494
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32725
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: mooli tayer <mtayer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/toolTests.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  mooli tayer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32c23258e90ff8551131c2703ebd2c1238d46494
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list