Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

nsoffer at redhat.com nsoffer at redhat.com
Sun Sep 14 18:34:26 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 9:

(1 comment)

The patch is in great shape now.

Unfortunately a rebase is required after http://gerrit.ovirt.org/31775 was merged.

http://gerrit.ovirt.org/#/c/30909/9//COMMIT_MSG
Commit Message:

Line 11: 
Line 12: multipath.conf should not be changed since important changes
Line 13: done by the sysadmin are needed and might be overwritten.
Line 14: 
Line 15: Now it will be reconfigured only on user demand.
While all this is correct, it does not emphasize the important change:

Previously multipath configuration was overwritten silently if configuration was required when vdsm started. Now vdsm will fail to start if multipath configuration is required, and the user will have to run "vdsm-tool configure --module multipath" so she has more control over the configuration, and the behavior is consistent with other modules (e.g. libvirt).
Line 16: 
Line 17: Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Line 18: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076531


-- 
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list