Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

nsoffer at redhat.com nsoffer at redhat.com
Sun Sep 14 12:35:38 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: qemuimg: Create qcow2 compat 0.10 images
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32836/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 136:     if rc != 0:
Line 137:         raise QImgError(rc, out, err)
Line 138: 
Line 139: 
Line 140: def _supports_qcow2_compat():
> Too bad we can't memoize this.
We can cash the value based on the timestamp of the executable, but I'm not sure we care about running another tiny process when creating an image.
Line 141:     """
Line 142:     TODO: Remove this when qemu versions providing the "compat" option are
Line 143:     available on all platforms.
Line 144:     """


-- 
To view, visit http://gerrit.ovirt.org/32836
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list