Change in vdsm[master]: config: introduce a devel section

danken at redhat.com danken at redhat.com
Sat Sep 13 16:13:55 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: config: introduce a devel section
......................................................................


config: introduce a devel section

This patch introduces a 'devel' configuration section,
in order to unclutter a bit the already crowded 'vars'
section.

An additional important benefit of this move is to clearly
mark that some tunables should never turned on in production
environments, unless exceptional circumstances, like a
performance problem being debugged.

For the same reason, is acceptable to move these options
across minor versions (e.g. 3.5 to 3.6).

This patch also makes room for future options which are
currently being discussed, like memory profiling or
a debug manhole service.

Change-Id: I7f9fc14c6fffd7ba111af985586eada83ec3c345
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32664
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/profile.py
M tests/profileTests.py
3 files changed, 24 insertions(+), 18 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/32664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f9fc14c6fffd7ba111af985586eada83ec3c345
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list