Change in vdsm[master]: tests: split tests fakes in a module

mpolednik at redhat.com mpolednik at redhat.com
Sat Sep 13 15:58:14 UTC 2014


Martin Polednik has posted comments on this change.

Change subject: tests: split tests fakes in a module
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/32650/3/tests/vmApiTests.py
File tests/vmApiTests.py:

Line 64: 
Line 65: 
Line 66: class TestVmStats(TestSchemaCompliancyBase):
Line 67:     def testDownStats(self):
Line 68:         with fake.VM() as testvm:
> Why not simply "vm"?
agreed on this one, not sure if I'd consider that a patch blocker though
Line 69:             testvm.setDownStatus(define.ERROR, vmexitreason.GENERIC_ERROR)
Line 70:             self.assertVmStatsSchemaCompliancy('ExitedVmStats',
Line 71:                                                testvm.getStats())
Line 72: 


-- 
To view, visit http://gerrit.ovirt.org/32650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list