Change in vdsm[master]: qemuimg: Create qcow2 compat 0.10 images

amureini at redhat.com amureini at redhat.com
Fri Sep 12 10:46:53 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: qemuimg: Create qcow2 compat 0.10 images
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/32836/1//COMMIT_MSG
Commit Message:

Line 17: use the "-o ?" option to detect the availability of the "compat" option
Line 18: before creating an image. This is the same method used by libvirt.
Line 19: 
Line 20: When all supported platforms provide the "compat" option, we can remove
Line 21: the "compat" detection code and use the newer 1.1 format.
There are two issues here:
1. wherether qemu has or hasn't compat.
2. the format on disk. regardless of the host version, if you're creating an image in a V3 domain, EVERY host that can access it should be able to read it, regardless of the qmeu/libvirt/vdsm version it's running. To use compat=1.1 we'd need a new storage format.
Line 22: 
Line 23: Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c
Line 24: Bug-Url: https://bugzilla.redhat.com/1139707


-- 
To view, visit http://gerrit.ovirt.org/32836
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd45b394c49e8b12fb7a4cbaa5c7a3519a2cc1c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Kevin Wolf <kwolf%redhat.com at gtempaccount.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list