Change in vdsm[master]: tc: Integrate Host QoS with network deletion via setupNetworks

danken at redhat.com danken at redhat.com
Fri Sep 12 09:00:18 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tc: Integrate Host QoS with network deletion via setupNetworks
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/31440/7/vdsm/network/configurators/qos.py
File vdsm/network/configurators/qos.py:

Line 74: 
Line 75: 
Line 76: def _uses_classes(device, root_qdisc_handle=None):
Line 77:     """Returns true iff there's traffic classes in the device, ignoring the
Line 78:     root class and a default unused class. Parent """
truncated docstring?
Line 79:     if root_qdisc_handle is None:
Line 80:         root_qdisc_handle = _root_qdisc(tc._qdiscs(device))['handle']
Line 81:     classes = [cls for cls in tc._classes(device, parent=root_qdisc_handle) if
Line 82:                not cls.get('root')]


-- 
To view, visit http://gerrit.ovirt.org/31440
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a3676af1553052e7cdea515faa29e847b7d3c0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list