Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.

danken at redhat.com danken at redhat.com
Fri Sep 12 08:25:41 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tool: bump CONF_VERSION to 4.17.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32707/2//COMMIT_MSG
Commit Message:

Line 9: In a recent commit changing configuration[1]
Line 10: I missed the version bumping while rebasing & moving around.
Line 11: 
Line 12: This was tested by me on clean install, but upon upgrade
Line 13: deleted logging entries would not be removed.
> Can you make it more clear what is the result of not updating  CONF_VERSION
"without this patch, upgrade from ovirt-3.4 does not trigger a reconfiguration of libvirt.conf, and does not apply the changes of [1] onto it."

Since [1] is a mere optimization, I am not sure that it is important enough to merit a version bump.
Line 14: 
Line 15: [1] http://gerrit.ovirt.org/#/c/31135/
Line 16: 
Line 17: Change-Id: I496392fa3a69b3a83a3f9b3934248e0b4fb4dab6


-- 
To view, visit http://gerrit.ovirt.org/32707
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I496392fa3a69b3a83a3f9b3934248e0b4fb4dab6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list