Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

apahim at redhat.com apahim at redhat.com
Fri Sep 12 05:18:19 UTC 2014


Amador Pahim has posted comments on this change.

Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/31529/12/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 355: 
Line 356:     @logDecorator
Line 357:     def sysctlCmd(self, key, value):
Line 358:         option = '='.join([key, value])
Line 359:         cmd = ['/usr/sbin/sysctl', '-w', option]
Sorry, I left this here. Next patch set will change to CommandPath, as indicated in last review.
Line 360:         rc, out, err = utils.execCmd(cmd)
Line 361:         if rc:
Line 362:             self.log.error("Sysctl -w command failed rc=%s, "
Line 363:                            "out=\"%s\", err=\"%s\"", rc, out, err)


-- 
To view, visit http://gerrit.ovirt.org/31529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list