Change in vdsm[master]: netlink: event monitor

asegurap at redhat.com asegurap at redhat.com
Thu Sep 11 23:14:48 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: netlink: event monitor
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.ovirt.org/#/c/32626/9/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:

Line 86:                     yield self.queue.get_nowait()
Line 87:                 else:
Line 88:                     yield self.queue.get()
Line 89:         except Queue.Empty:
Line 90:             pass
If the queue is empty I think that the usual thing to do is to raise StopIteration
Line 91: 
Line 92:     def start(self):
Line 93:         if self.thread.isAlive():
Line 94:             raise MonitorError('The monitor has already started')


Line 106: class StopMonitor(Exception):
Line 107:     pass
Line 108: 
Line 109: 
Line 110: class MonitorThread(threading.Thread):
You should mark the thread to be daemonic so it doesn't hold the process exit.
Line 111:     def __init__(self, monitor):
Line 112:         threading.Thread.__init__(self)
Line 113:         self.monitor = monitor
Line 114:         self._stop = threading.Event()


-- 
To view, visit http://gerrit.ovirt.org/32626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23ea72986564c5a115e36be0e7cf679c28c8ea96
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list