Change in vdsm[master]: virt: vm: sanitize earlier the 'smp' parameter

fromani at redhat.com fromani at redhat.com
Thu Sep 11 15:30:53 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: vm: sanitize earlier the 'smp' parameter
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

a spurious 'print' sneaked in.

http://gerrit.ovirt.org/#/c/32827/1/tests/vmTests.py
File tests/vmTests.py:

Line 1799: 
Line 1800: class TestVmSanity(TestCaseBase):
Line 1801:     def testSmpPresentIfNotSpecified(self):
Line 1802:         with FakeVM() as testvm:
Line 1803:             print testvm.conf
oops. Will remove.
Line 1804:             self.assertEqual(int(testvm.conf['smp']), 1)
Line 1805: 
Line 1806:     def testSmpByParameters(self):
Line 1807:         smp = 4


-- 
To view, visit http://gerrit.ovirt.org/32827
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b90a26ff6af560359f3d60a73afc56fb25dc15c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list