Change in vdsm[master]: vm: rename obsolete buildCmdLine method

danken at redhat.com danken at redhat.com
Thu Sep 11 15:14:35 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: rename obsolete buildCmdLine method
......................................................................


vm: rename obsolete buildCmdLine method

In past times, VDSM used to run QEMU.
The Vm._buildCmdLine method was in charge
to build the QEMU executable command line.

Nowadays we use libvirt as middleware, with no
plans to come back, so this method does a different
thing.

This patch renames this method, with no behaviour
change, to reflect the reality.

Please note that this method is mostly orchestration
of vmxml.Domain calls;
Future patches will split this code from vm.py
to vmxml.py.

Change-Id: If4129948e71bf2308cce0b02f0d6c800903004bf
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32829
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/32829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4129948e71bf2308cce0b02f0d6c800903004bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list