Change in vdsm[master]: tests: split tests fakes in a module

fromani at redhat.com fromani at redhat.com
Thu Sep 11 13:07:01 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: tests: split tests fakes in a module
......................................................................


Patch Set 3: Verified+1

renamed vmtestlib -> vmfakelib
renamed Fake* -> fake.* into client code
renamed ConnectionMock to Connection along the way
renamed fake.Vm() instances to 'testvm' (instead of the poorly-choosed 'fake' used previously) to avoid name clash - also a bit nicer.

Ticking 'V+1' because all test pass cleanly

-- 
To view, visit http://gerrit.ovirt.org/32650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list