Change in vdsm[master]: vm: implement VM.sdIds as read-only property

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 11 10:33:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: implement VM.sdIds as read-only property
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32796/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5597:     def sdIds(self):
Line 5598:         """
Line 5599:         Returns a list of the ids of the storage domains in use by the VM.
Line 5600:         """
Line 5601:         return [device.domainID for device in self._devices[DISK_DEVICES]]
> Ok. Is domainID enough to stablish this? In this case that line can be chan
Possible, but the blessed way is using isVdsmImage(device).

And note that we need a set, not a list:

   return set(device.domainID for device in ...
              if isVdsmImage(device))
Line 5602: 
Line 5603: 
Line 5604: class LiveMergeCleanupThread(threading.Thread):
Line 5605:     def __init__(self, vm, jobId, drive, doPivot):


-- 
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list