Change in vdsm[master]: vm: implement VM.sdIds as read-only property

nsoffer at redhat.com nsoffer at redhat.com
Thu Sep 11 06:10:20 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: implement VM.sdIds as read-only property
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32796/1//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Changed the VM object sdIds list attribute. It used to be a list that kept a copy of the storage domains in use in an additional list (with all the difficulties of keeping the list in sync). That list has been replaced with a property that returns the storage domains in use getting them directly from the the vm devices in use.
Line 10: 
Line 11: Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Line 12: Bug-Url: https://bugzilla.redhat.com/1094518
This is not enough to close this bug, so better make this Relates-To: instead of Bug-Url:

Unless you plan a series of patches redesigning the current mess.


-- 
To view, visit http://gerrit.ovirt.org/32796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie445d4689aa562b00229844007ffa05eaecebdcb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabio Pliger <fabio.pliger at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list