Change in vdsm[master]: make: Run fast checks before slow ones

danken at redhat.com danken at redhat.com
Wed Sep 10 21:40:49 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: make: Run fast checks before slow ones
......................................................................


make: Run fast checks before slow ones

Previously the slow tests where run before the fast pyflakes and pep8
checks, so developer discover unused arguments or whitespace issues only
after 1-2 minutes instead of few seconds.

Now make check runs the fast checks before the slow ones, saving
developer time.

This is implemented by extracting the unrelated checks from check-local
into separate phony targets. This is useful when debugging specific
issues or when creating automated jobs that run specific checks.

Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32532
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M Makefile.am
1 file changed, 26 insertions(+), 15 deletions(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/32532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list