Change in vdsm[master]: tool: Remove duplicate names

danken at redhat.com danken at redhat.com
Wed Sep 10 21:38:51 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: tool: Remove duplicate names
......................................................................


tool: Remove duplicate names

The configurators modules were duplicating the module name in the class
name:

    libvirt.Libvrit

This is not only ugly, but does not describe what this class is. Now all
the configurtors modules define a Configurator class instead:

    libvirt.Configurator

This also has the nice property that it is now harder to import class
names into other modules, so people will import the modules instead.

Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31775
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/configurator.py
M lib/vdsm/tool/configurators/certificates.py
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/configurators/sanlock.py
M tests/toolTests.py
5 files changed, 17 insertions(+), 17 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list