Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves

danken at redhat.com danken at redhat.com
Wed Sep 10 15:04:48 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ethtool_opts: provide a way to apply to all slaves
......................................................................


ethtool_opts: provide a way to apply to all slaves

There was a hole in the feature that this hook services in that it
was not possible to apply some opts to all the slaves in the
cases when the combination of settings was not appliable to all
the slaves in a single ethtool command.

This patch solves the bug by adding a special device name that
the admin can use when defining the custom network opts, i.e.,
'*' that will mean that the special device name will be replaced
with each of the slave names, one at a time, and run as many ethtool
procs as there are slaves in the bond.

Bug-Url: https://bugzilla.redhat.com/1126478
Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32508
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/hooking.py
M vdsm_hooks/ethtool_options/README
M vdsm_hooks/ethtool_options/ethtool_options.py
3 files changed, 60 insertions(+), 21 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list