Change in vdsm[master]: Do not add the memtune/min_guarantee element to the libvirt xml

fromani at redhat.com fromani at redhat.com
Wed Sep 10 14:30:24 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Do not add the memtune/min_guarantee element to the libvirt xml
......................................................................


Patch Set 3:

The simple creation flow looks OK. I'm concerned with migrations, both live migrations and hibernation/restore (both these paths happen to share a lot of common code)

At glance, the filtering you added may be sufficient. Otherwise, we probably need to filter out the configuration param 'memGuaranteedSize' in the Vm.__init__() method - maybe with an added warning.

-- 
To view, visit http://gerrit.ovirt.org/32774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9a5a467ecee3235c842aa0b9b5fa9ccfd31ed9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list