Change in vdsm[ovirt-3.5]: unified_persistence: only consider bonds created/touched by ...

danken at redhat.com danken at redhat.com
Wed Sep 10 13:40:51 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: unified_persistence: only consider bonds created/touched by vdsm
......................................................................


unified_persistence: only consider bonds created/touched by vdsm

When upgrading a system to unified persistence we were considering
any non empty bond as a bond to persist under unified persistence.
This was not consistent with our implementation of ifcfg.flush that
only considers ifcfg files with the vdsm authoring header.

The patch fixes the behavior by making ifcfg flush and
unified_persistence upgrade consistent in it's ownership semantics,
i.e., we will not touch nor consider for persistence files not
markedly authored by vdsm.

A side effect of the lack of consistency was that a bond that was
providing connectivity to a machine could be made to be onboot no
if it was not immediately the backing device of ovirtmgmt.

Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22
Bug-Url: https://bugzilla.redhat.com/1128140
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32703
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32769
---
M lib/vdsm/tool/unified_persistence.py
1 file changed, 17 insertions(+), 3 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32769
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f65546c55396ddf7022f5ffe17540ce0680d22
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list