Change in vdsm[master]: multipath: Disable queuing on all multipath devices

Federico Simoncelli fsimonce at redhat.com
Wed Sep 10 11:19:38 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: multipath: Disable queuing on all multipath devices
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/32277/3/vdsm/storage/vdsm-multipath.rules.in
File vdsm/storage/vdsm-multipath.rules.in:

Line 15: #
Line 16: # See https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html-single/DM_Multipath/index.html#queueifnopath_issues
Line 17: #
Line 18: 
Line 19: ACTION=="add|change", ENV{DM_UUID}=="mpath-?*", RUN+="@DMSETUP_PATH@ message $env{DM_NAME} 0 fail_if_no_path"
This looks good but I think we should come up with a common fix for both fail_if_no_path and replacement_timeout (bz#980139).

While we wait for multipath to handle all these issues I think we should fix them ourselves in one place only (instead of polluting a system-wide config file as iscsid.conf).

So we could have an utility that on mpath add|change runs all the checks both for iscsi and fcp (fast_io_fail_tmo/dev_loss_tmo?).

Once multipath will be fixed we'll have just to remove the udev rule and the utility.


-- 
To view, visit http://gerrit.ovirt.org/32277
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6bfe68f4a8d233afe1bb787ce028ffb4c167469b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list