Change in vdsm[master]: tool: bump CONF_VERSION to 4.17.

mtayer at redhat.com mtayer at redhat.com
Wed Sep 10 09:13:09 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: bump CONF_VERSION to 4.17.
......................................................................


Patch Set 2:

Actually after inspecting the code again I see that:

1.) libvirt will ALWAYS require --force in order to not fail
configure[1] 

2.) --force will remove conf and rewrite anyway

This actually means we NEVER HAVE TO BUMP VERSION,
and that the version number has no significance
(and thus should be removed, I will do so if you agree)

@Yaniv, @Nir do you agree?


[1] that is since it returns NOT_SURE at best from isconfigured.

-- 
To view, visit http://gerrit.ovirt.org/32707
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I496392fa3a69b3a83a3f9b3934248e0b4fb4dab6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list