Change in vdsm[master]: sampling: do not produce stats for missing disks

fromani at redhat.com fromani at redhat.com
Wed Sep 10 08:55:59 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: sampling: do not produce stats for missing disks
......................................................................


Patch Set 3: Verified+1

Re-verified:

Thread-13::DEBUG::2014-09-10 10:42:44,741::vm::3566::vm.Vm::(hotplugDisk) vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Hotplug disk xml: <disk device="disk" snapshot="no" type="block">
        <address bus="0x00" domain="0x0000" function="0x0" slot="0x07" type="pci"/>
        <source dev="/rhev/data-center/00000002-0002-0002-0002-0000000003dd/8ceb838a-4e74-420d-b1e2-817c0e9f8eea/images/84142b8c-7c06-4767-9ff9-16f43597fbad/0d781ab0-4b01-4ab2-8e81-fa11a9a830ed"/>
        <target bus="virtio" dev="vdb"/>
        <serial>84142b8c-7c06-4767-9ff9-16f43597fbad</serial>
        <driver cache="none" error_policy="stop" io="native" name="qemu" type="qcow2"/>
</disk>

then, after some time:
GENji> 10:53:08 root [~]$ vdsClient localhost getAllVmStats | grep vdb
	disks = {'vda': {'readLatency': '0', 'apparentsize': '11811160064', 'writeLatency': '0', 'imageID': 'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '11811160064', 'writeRate': '0.00'}, 'vdb': {'readLatency': '0', 'apparentsize': '1073741824', 'writeLatency': '0', 'imageID': '84142b8c-7c06-4767-9ff9-16f43597fbad', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '1073741824', 'writeRate': '0.00'}, 'hdc': {'readLatency': '0', 'apparentsize': '0', 'writeLatency': '0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '0', 'writeRate': '0.00'}}


(no error in the logs).

Thread-13::DEBUG::2014-09-10 10:54:33,173::vm::3619::vm.Vm::(hotunplugDisk) vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Hotunplug disk xml: <disk device="disk" snapshot="no" type="block">
        <address bus="0x00" domain="0x0000" function="0x0" slot="0x07" type="pci"/>
        <source dev="/rhev/data-center/00000002-0002-0002-0002-0000000003dd/8ceb838a-4e74-420d-b1e2-817c0e9f8eea/images/84142b8c-7c06-4767-9ff9-16f43597fbad/0d781ab0-4b01-4ab2-8e81-fa11a9a830ed"/>
        <target bus="virtio" dev="vdb"/>
        <serial>84142b8c-7c06-4767-9ff9-16f43597fbad</serial>
        <driver cache="none" error_policy="stop" io="native" name="qemu" type="qcow2"/>
</disk>

and

GENji> 10:55:18 root [~]$ vdsClient localhost getAllVmStats | grep disks
	disks = {'vda': {'readLatency': '0', 'apparentsize': '11811160064', 'writeLatency': '0', 'imageID': 'd5ed26d5-3d35-4ef8-b52c-a65d99e12ad0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '11811160064', 'writeRate': '0.00'}, 'hdc': {'readLatency': '0', 'apparentsize': '0', 'writeLatency': '0', 'flushLatency': '0', 'readRate': '0.00', 'truesize': '0', 'writeRate': '0.00'}}

-- 
To view, visit http://gerrit.ovirt.org/30029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If93572c21ecd47fe0bb2a6c6e13c0555034be881
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list