Change in vdsm[master]: tool: Remove duplicate names

fromani at redhat.com fromani at redhat.com
Wed Sep 10 06:51:04 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: tool: Remove duplicate names
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

ncie :)

http://gerrit.ovirt.org/#/c/31775/7//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: The configurators modules were duplicating the module name in the class
Line 10: name:
Line 11: 
Line 12:     libvirt.Libvrit
typo, but not worthy a resubmit IMO.
Line 13: 
Line 14: This is not only ugly, but does not describe what this class is. Now all
Line 15: the configurtors modules define a Configurator class instead:
Line 16: 


-- 
To view, visit http://gerrit.ovirt.org/31775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list