Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves

danken at redhat.com danken at redhat.com
Tue Sep 9 21:36:46 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ethtool_opts: provide a way to apply to all slaves
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/32508/6/vdsm_hooks/ethtool_options/ethtool_options.py
File vdsm_hooks/ethtool_options/ethtool_options.py:

Line 102:     options = attrs['custom'].get('ethtool_opts')
Line 103:     success = True
Line 104:     if options is not None:
Line 105:         nics = _net_nics(attrs)
Line 106:         for subcmd in _parse_into_subcommands(options.split()):
Sorry for not getting back to you earlier. We can have

if subcmd.device == ALL_SLAVES:
    expended_nics = nics
else:
    _validate_dev_ownership(nics, network, subcmd)
    expended_nics = [subcmd.device]
for nic in expended_nics:
    try-block

What say you?
Line 107:             if subcmd.device == ALL_SLAVES:
Line 108:                 for nic in nics:
Line 109:                     try:
Line 110:                         _set_ethtool_opts(network,


-- 
To view, visit http://gerrit.ovirt.org/32508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list