Change in vdsm[master]: vm: migration: exponential downtime increment

danken at redhat.com danken at redhat.com
Tue Sep 9 16:41:21 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: migration: exponential downtime increment
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25820/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 353:             if not self._preparingMigrationEvt:
Line 354:                     raise
Line 355: 
Line 356: 
Line 357: def exponential_downtime(downtime, steps):
would you add a unit test for this function?

 >>> list(exponential_downtime(500, 10))
 [451, 451, 452, 453, 454, 457, 460, 465, 472, 483]

makes very little sense to me.
Line 358:     offset = downtime - (downtime / steps)
Line 359:     base = (downtime - offset) ** (1 / float(steps))
Line 360: 
Line 361:     for i in range(steps):


-- 
To view, visit http://gerrit.ovirt.org/25820
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list