Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves

asegurap at redhat.com asegurap at redhat.com
Tue Sep 9 16:31:43 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ethtool_opts: provide a way to apply to all slaves
......................................................................


Patch Set 6: Verified+1

Ran the same verification as before and checked also that even when one of the commands is repeated and makes ethtool return 80 as rc, we log the subcommand failure, execute the rest of the subcommands and in the end exit the hook noting that some subcmd failed (which does not fail the setupNetworks op and will leave enough logging traces for the admin to determine if the errors were acceptable).

-- 
To view, visit http://gerrit.ovirt.org/32508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list