Change in vdsm[master]: tool: use natural numbers for configuration versioning.

mtayer at redhat.com mtayer at redhat.com
Tue Sep 9 15:33:01 UTC 2014


mooli tayer has uploaded a new change for review.

Change subject: tool: use natural numbers for configuration versioning.
......................................................................

tool: use natural numbers for configuration versioning.

Currently we use a vdsm version but only bump it when the
configuration actually changed.(so in 4.15 this was 4.13)

This can be misleading, and several bugs where opened
due to this issue[1].

I'm  suggesting to use natural numbers and counting on the fact
that configuration should be bumped for next version[2].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1133955
There was another bug on this that I cannot locate.
[2] Ifa8f02f0e6e1793007a8b3be49fe8a2f74076b19

Change-Id: I8f50e30fe03acb101aed4b1a7aece196a77b4c6b
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/32708/1

diff --git a/lib/vdsm/tool/configurators/libvirt.py b/lib/vdsm/tool/configurators/libvirt.py
index dde199c..24726bb 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -302,7 +302,7 @@
     # version != PACKAGE_VERSION since we do not want to update configuration
     # on every update. see 'configuration versioning:' at Configfile.py for
     # details.
-    CONF_VERSION = '4.17.0'
+    CONF_VERSION = '1'
 
     PKI_DIR = os.path.join(constants.SYSCONF_PATH, 'pki/vdsm')
     LS_CERT_DIR = os.path.join(PKI_DIR, 'libvirt-spice')


-- 
To view, visit http://gerrit.ovirt.org/32708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f50e30fe03acb101aed4b1a7aece196a77b4c6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list