Change in vdsm[master]: vdsm: making PM 'on' and 'off' sync

danken at redhat.com danken at redhat.com
Tue Sep 9 14:32:49 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: making PM 'on' and 'off' sync
......................................................................


Patch Set 2: Code-Review-1

How did you verify this patch? We were forced to use asynchronous call to the fence script, since Engine could not wait for so long.

(prehistoric commit a9db31fe4d4d3aeef21f)

What happens now if the fence_agent script hangs for minutes? What would happen to the still-supported engine-3.0?

-- 
To view, visit http://gerrit.ovirt.org/32695
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d45977664c99c954c4663a26642e6e21cc65e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list