Change in vdsm[master]: tests: split vm tests helpers in a module

mpolednik at redhat.com mpolednik at redhat.com
Tue Sep 9 08:56:37 UTC 2014


Martin Polednik has posted comments on this change.

Change subject: tests: split vm tests helpers in a module
......................................................................


Patch Set 2: Code-Review+1

I would consider lowercase module names ("Modules should have short, all-lowercase names." from pep8), but that depends how consistent we want the code to be with other tests of course ;) otherwise, perfect!

-- 
To view, visit http://gerrit.ovirt.org/32650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list