Change in vdsm[master]: profiling: Add support for memory profiling

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 9 08:27:38 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: profiling: Add support for memory profiling
......................................................................


Patch Set 4:

(1 comment)

I think we should move this into the new profiling package:

  lib/vdsm/profiling/mem.py

http://gerrit.ovirt.org/#/c/32019/4/vdsm/vdsm
File vdsm/vdsm:

Line 69:     signal.signal(signal.SIGUSR1, sigusr1Handler)
Line 70:     zombiereaper.registerSignalHandler()
Line 71: 
Line 72:     profile.start()
Line 73:     profile_mem.start()
Lets replace this with:

    from vdsm import profiling
    ...
    profiling.start()

An let the profiling package start all profilers. I don't like to modify vdsm again when we add new profilers.
Line 74: 
Line 75:     libvirtconnection.start_event_loop()
Line 76: 
Line 77:     if config.getboolean('irs', 'irs_enable'):


-- 
To view, visit http://gerrit.ovirt.org/32019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list