Change in vdsm[master]: make: Run fast checks before slow ones

nsoffer at redhat.com nsoffer at redhat.com
Mon Sep 8 21:17:39 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: make: Run fast checks before slow ones
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32532/1/Makefile.am
File Makefile.am:

Line 109: 	done ; \
Line 110: 	$(PEP8) --exclude="$${exclude}" --filename '*.py,*.py.in' .
Line 111: 	$(PEP8) $(PEP8_WHITELIST)
Line 112: 
Line 113: # Note: dependencies ordered by time needed to run them
> Sorry, I still do not understand the purpose of the change to check-recursi
check-local is performed *after* check-recursive has run the tests in all the subdirectories (about 45 seconds on my laptop).

Adding dependencies to check-recursive cause them to run *before* check-recursive.

About -j - we don't care about order when running parallel make :-)
Line 114: check-recursive: gitignore pyflakes pep8
Line 115: 
Line 116: all-local: \
Line 117: 	vdsm.spec


-- 
To view, visit http://gerrit.ovirt.org/32532
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3eb8060c5caacddb1c94046ec14daec88c00817
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list