Change in vdsm[master]: ethtool_opts: provide a way to apply to all slaves

danken at redhat.com danken at redhat.com
Mon Sep 8 15:16:43 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ethtool_opts: provide a way to apply to all slaves
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32508/3/vdsm_hooks/ethtool_options/ethtool_options.py
File vdsm_hooks/ethtool_options/ethtool_options.py:

Line 108:                     _set_ethtool_opts(
Line 109:                         network,
Line 110:                         [subcmd.name, nic if subcmd.device == ALL_SLAVES else
Line 111:                          subcmd.device] + subcmd.flags)
Line 112:         else:  # No bonding or specific slaves case
I think that we're still over complex. How about something like

for subcmd in subcommands:
  if subcmd.device != ALL_SLAVES:
    _validate_nic_ownership(..)
    nics = [subcmd.device]
  for nic in nics:
    _set_ethtool_opts(...)
Line 113:             _validate_dev_ownership(_net_nics(attrs), network, subcommands)
Line 114:             for subcmd in subcommands:
Line 115:                 _set_ethtool_opts(network, [subcmd.name, nic] + subcmd.flags)
Line 116: 


-- 
To view, visit http://gerrit.ovirt.org/32508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddbc167be4ac8ba7c4b4ab10da0275b4caf2a58
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list