Change in vdsm[master]: vdsm: move general devices to vmdevices

fromani at redhat.com fromani at redhat.com
Mon Sep 8 07:42:22 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: move general devices to vmdevices
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/32294/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-02 11:31:41 +0200
Line 4: Commit:     Martin Polednik <mpolednik at redhat.com>
Line 5: CommitDate: 2014-09-02 11:31:41 +0200
Line 6: 
Line 7: vdsm: move general devices to vmdevices
please use the 'virt' prefix.
Line 8: 
Line 9: No code changes, only moving around
Line 10: 
Line 11: Change-Id: I2a904346d7ef3b4f3a89e68030e44e21377b7645


http://gerrit.ovirt.org/#/c/32294/1/vdsm/virt/vmdevices.py
File vdsm/virt/vmdevices.py:

Line 44:                  if not a.startswith('__')]
Line 45:         return ' '.join(attrs)
Line 46: 
Line 47: 
Line 48: class GeneralDevice(Base):
It would be great to add a one/two line docstring documenting how we use this class. However, this can wait for a future patch.
Line 49: 
Line 50:     def getXML(self):
Line 51:         """
Line 52:         Create domxml for general device


-- 
To view, visit http://gerrit.ovirt.org/32294
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a904346d7ef3b4f3a89e68030e44e21377b7645
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list