Change in vdsm[master]: vdsm: move sound device to vmdevices

fromani at redhat.com fromani at redhat.com
Mon Sep 8 07:40:26 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: move sound device to vmdevices
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/29265/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-02 11:50:03 +0200
Line 4: Commit:     Martin Polednik <mpolednik at redhat.com>
Line 5: CommitDate: 2014-09-02 12:06:19 +0200
Line 6: 
Line 7: vdsm: move sound device to vmdevices
please use the 'virt' prefix (tag?)

Moreover, a minor note: being terse is a plus. No need to be needlessy verbose in the commit message while the patch is pretty self-explanatory.

However, I'd add a few (literally one or two) lines in the commit message to document that we're moving devices out of vm.py and that his patch is part of a series, for future reference.
Line 8: 
Line 9: no code changes, just moving things around
Line 10: 
Line 11: Change-Id: I42b8ae3475373d39c7d6375ccbc23a85437e19d0


-- 
To view, visit http://gerrit.ovirt.org/29265
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b8ae3475373d39c7d6375ccbc23a85437e19d0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list