Change in vdsm[master]: tests: new functional tests for vdsm storage

ykleinbe at redhat.com ykleinbe at redhat.com
Sun Sep 7 13:07:14 UTC 2014


Yoav Kleinberger has posted comments on this change.

Change subject: tests: new functional tests for vdsm storage
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/32496/2//COMMIT_MSG
Commit Message:

Line 24: Currently, only localfs and iscsi are supported. Other storage backends
Line 25: will be added later.
Line 26: 
Line 27: Change-Id: I1703e7c1dc223ff707775865cd14c7dd62314caf
Line 28: Bug-Url: https://bugzilla.redhat.com/??????
> No need for bug url.
Done


http://gerrit.ovirt.org/#/c/32496/2/tests/functional/testlib/controlvdsm.py
File tests/functional/testlib/controlvdsm.py:

Line 22:                 vdsmClient.getStorageDomainsList()
Line 23:                 logging.info('connection to VDSM succeeded')
Line 24:                 return
Line 25:             except socket.error as e:
Line 26:                 logging.warning('could not talk to VDSM: %s' % e)
> I think we just talked to vdsm, but it would not listen :-)
Done
Line 27:                 time.sleep(1)
Line 28: 
Line 29:         raise Exception('could not connect to VDSM')
Line 30: 


-- 
To view, visit http://gerrit.ovirt.org/32496
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1703e7c1dc223ff707775865cd14c7dd62314caf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list