Change in vdsm[master]: vdsm: user super instead of direct parent call for NIC

danken at redhat.com danken at redhat.com
Sun Sep 7 08:11:03 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: user super instead of direct parent call for NIC
......................................................................


Patch Set 1:

(1 comment)

Too many spelling mistakes, patch is fine.

http://gerrit.ovirt.org/#/c/32400/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-03 15:33:31 +0200
Line 4: Commit:     Martin Polednik <mpolednik at redhat.com>
Line 5: CommitDate: 2014-09-03 15:33:31 +0200
Line 6: 
Line 7: vdsm: user super instead of direct parent call for NIC
Please drop the vdsm prefix.

User->use
Line 8: 
Line 9: Super allow us to call parent class without having to specify
Line 10: it's name, simplyfing further moving of the class and possibly
Line 11: more inheritance.


-- 
To view, visit http://gerrit.ovirt.org/32400
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc30c816be7e7ef91b921477519cefc11aa76cd6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list