Change in vdsm[master]: oop: Use a single instance of IOProcess per SD

ybronhei at redhat.com ybronhei at redhat.com
Fri Sep 5 23:27:23 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: oop: Use a single instance of IOProcess per SD
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/31501/4/vdsm/storage/outOfProcess.py
File vdsm/storage/outOfProcess.py:

Line 83:                 else:
Line 84:                     _procPool[clientName] = (time.time(), proc)
Line 85:                     return proc
Line 86:         else:
Line 87:             return _rfhPool[clientName]
don't you need that also under the _procPoolLock?
Line 88:     except KeyError:
Line 89:         with _procPoolLock:
Line 90:             if _oopImpl == IOPROC:
Line 91:                 proc = _OopWrapper(IOProcess(max_threads=HELPERS_PER_DOMAIN,


Line 99:             else:
Line 100:                 _rfhPool[clientName] = _OopWrapper(
Line 101:                     RemoteFileHandlerPool(HELPERS_PER_DOMAIN))
Line 102: 
Line 103:                 return _rfhPool[clientName]
i'd put all of it under "with _procPoolLock"
Line 104: 
Line 105: 
Line 106: def getGlobalProcPool():
Line 107:     return getProcessPool(GLOBAL)


-- 
To view, visit http://gerrit.ovirt.org/31501
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I383fe617ee4ce22de368ba54f980887d70ff37c5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list