Change in vdsm[master]: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem i...

danken at redhat.com danken at redhat.com
Fri Sep 5 16:19:55 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ppc: Over ppc arch vdsm reports UNKNOWN as operationSystem in getVdsCaps
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32444/3/vdsm/caps.py
File vdsm/caps.py:

Line 65:     RHEL = 'RHEL'
Line 66:     FEDORA = 'Fedora'
Line 67:     RHEVH = 'RHEV Hypervisor'
Line 68:     DEBIAN = 'Debian'
Line 69:     POWER = 'PowerKVM'
Sorry to nag and repeat my naming request: please call it

 POWERKVM = 'PowerKVM'

("Power" sounds too generic to me. reminds me of "Word")
Line 70: 
Line 71: 
Line 72: class AutoNumaBalancingStatus:
Line 73:     DISABLE = 0


-- 
To view, visit http://gerrit.ovirt.org/32444
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list