Change in vdsm[master]: debug: Integrate manhole debugging service

fromani at redhat.com fromani at redhat.com
Fri Sep 5 12:20:53 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: debug: Integrate manhole debugging service
......................................................................


Patch Set 2:

I see Nir's point, but signal is very convenient.

A good way to accomodate both convenience and safety could be

* config option to enable/disable the service; so, in development or when debug is required, the admin must be aware of the presence of the manhole
* a signal to 'open' the manhole, so it could be enabled on demand and we gain agility on complex scenarios like hunting the memleaks.

-- 
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a6cdf97ddce446bea527e771eb641f969b1a532
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list