Change in vdsm[master]: debug: Integrate manhole debugging service

nsoffer at redhat.com nsoffer at redhat.com
Fri Sep 5 11:10:39 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: debug: Integrate manhole debugging service
......................................................................


Patch Set 2:

What you suggest is convenient, but it gives someone out of the machine too much control.

We can use the activate_on=SIGUSR2 option to start the manhole when receiving a singal. To stop the manhole thread, we can arrange a function in the manhole shell that stop the manhole thread.

But I don't think this complexity is needed. Restarting vdsm is a safe and fast operation, and a thread waiting on accept have practically zero cost.

-- 
To view, visit http://gerrit.ovirt.org/32147
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a6cdf97ddce446bea527e771eb641f969b1a532
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list