Change in vdsm[master]: hsm: validate storage pool in prepareImage

Federico Simoncelli fsimonce at redhat.com
Thu Sep 4 17:09:33 UTC 2014


Federico Simoncelli has uploaded a new change for review.

Change subject: hsm: validate storage pool in prepareImage
......................................................................

hsm: validate storage pool in prepareImage

If the storage pool is specified (non-blank) we should validate that
we're connected.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1130995
Change-Id: Ia85c2b2acedf7bdbadd930596987cc4828e24ddd
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/32502/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 722a858..2d1205e 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3228,6 +3228,11 @@
         """
         vars.task.getSharedLock(STORAGE, sdUUID)
 
+        # If the pool is not blank we should make sure that we are connected
+        # to the pool.
+        if spUUID != sd.BLANK_UUID:
+            self.getPool(spUUID)
+
         imgVolumesInfo = []
         dom = sdCache.produce(sdUUID)
         allVols = dom.getAllVolumes()


-- 
To view, visit http://gerrit.ovirt.org/32502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia85c2b2acedf7bdbadd930596987cc4828e24ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list