Change in vdsm[master]: virt: let Engine start a VM on an UNKOWN OS

fromani at redhat.com fromani at redhat.com
Thu Sep 4 11:15:37 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: let Engine start a VM on an UNKOWN OS
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/32459/1//COMMIT_MSG
Commit Message:

Line 16: Backward compatibility caveat: if a VM is started on an UNKOWN os, and
Line 17: then migrated to an old Vdsm (pre ovirt-3.4.2), it would be killed when
Line 18: that old Vdsm is to be restarted. It's not probable that someone would
Line 19: start a long-running VM on an UNKOWN platform, we may want to wait with
Line 20: this patch until ovirt-3.3 is deprecated.
Although I believe this is unlikely, I believe it is better to play it safe and wait a bit more before to have this patch in. Besides that, looks fine to me.
Line 21: 
Line 22: Change-Id: Iee7b3913e76923043daab8fb85854c3290208237


-- 
To view, visit http://gerrit.ovirt.org/32459
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee7b3913e76923043daab8fb85854c3290208237
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list