Change in vdsm[ovirt-3.5]: setNumberOfCpus marshalling issue

danken at redhat.com danken at redhat.com
Thu Sep 4 10:19:19 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: setNumberOfCpus marshalling issue
......................................................................


setNumberOfCpus marshalling issue

xmlrpc uses vmID twice to construct VM object and to run setNumberOfCpus.
In xmlrpc we provide implementation how we instantiate API object and
invoke a verb so we do not care how the parameters are used.

Whereas in jsonrpc we use "reflection" so we can't use the same parameter twice.


Bug-Url: https://bugzilla.redhat.com/1138181
Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/32454
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32454
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie95c23c15bdb9b4932cd36b6f60bf84149c76454
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list