Change in vdsm[master]: pyroute2: IPv6 support

osvoboda at redhat.com osvoboda at redhat.com
Thu Sep 4 09:46:26 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: pyroute2: IPv6 support
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Copy&paste bug ;-)

http://gerrit.ovirt.org/#/c/32033/2/vdsm/network/configurators/pyroute_two.py
File vdsm/network/configurators/pyroute_two.py:

Line 65:                 self.ip.routes.add({'dst': 'default',
Line 66:                                     'gateway': ipConfig.gateway}).commit()
Line 67:         if ipConfig.ipv6addr:
Line 68:             with self.ip.interfaces[iface.name] as i:
Line 69:                 i.add_ip(ipConfig.ipaddr)
This should be ipConfig.ipv6addr, I think.
Line 70:             if ipConfig.ipv6gateway:
Line 71:                 self.ip.routes.add({'dst': 'default',
Line 72:                                     'gateway': ipConfig.ipv6gateway}).commit()
Line 73:         if ipConfig.ipv6autoconf is not None:


-- 
To view, visit http://gerrit.ovirt.org/32033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list