Change in vdsm[master]: pyroute2: IPv6 support

asegurap at redhat.com asegurap at redhat.com
Thu Sep 4 09:09:06 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: pyroute2: IPv6 support
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/32033/1/vdsm/network/configurators/pyroute_two.py
File vdsm/network/configurators/pyroute_two.py:

Line 61:         if ipConfig.ipaddr:
Line 62:             with self.ip.interfaces[iface.name] as i:
Line 63:                 i.add_ip('%s/%s' % (ipConfig.ipaddr, ipConfig.netmask))
Line 64:             if ipConfig.gateway and ipConfig.defaultRoute:
Line 65:                 ipwrapper.routeAdd(['default', 'via', ipConfig.gateway])
this should be done with pyroute2 (on a separate patch)
Line 66:         if ipConfig.ipv6addr:
Line 67:             with self.ip.interfaces[iface.name] as i:
Line 68:                 i.add_ip(ipConfig.ipv6addr)
Line 69:             if ipConfig.ipv6gateway:


Line 67:             with self.ip.interfaces[iface.name] as i:
Line 68:                 i.add_ip(ipConfig.ipv6addr)
Line 69:             if ipConfig.ipv6gateway:
Line 70:                 ipwrapper.routeAdd(['default', 'via', ipConfig.ipv6gateway],
Line 71:                                    dev=iface.name, family=6)
this should be done with pyroute2
Line 72:         if ipConfig.ipv6autoconf is not None:
Line 73:             with open('/proc/sys/net/ipv6/conf/%s/autoconf' % iface.name,
Line 74:                       'w') as ipv6_autoconf:
Line 75:                 ipv6_autoconf.write('1' if ipConfig.ipv6autoconf else '0')


-- 
To view, visit http://gerrit.ovirt.org/32033
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6cb4542d1de107aba7a92d65b744290f8a9583
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list