Change in vdsm[master]: iscsi: Set node.session.timeo.replacement_timeout when creat...

sgotliv at redhat.com sgotliv at redhat.com
Thu Sep 4 07:09:32 UTC 2014


Sergey Gotliv has posted comments on this change.

Change subject: iscsi: Set node.session.timeo.replacement_timeout when creating a node
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/32363/1/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 164:             cp=True, persist=True)
Line 165:     with tempfile.NamedTemporaryFile() as f:
Line 166:         f.write(MPATH_CONF_TEMPLATE % {
Line 167:             'scsi_id_path': _scsi_id.cmd,
Line 168:             'fast_io_fail_tmo': constants.FAST_IO_FAIL_TIMEOUT})
> To get the new constant into the configuration?
:-) My bad. I missed the fact that you replaced the hardcoded value 5 with the placeholder which itself is should be replaced with the actual value.
Line 169:         f.flush()
Line 170:         cmd = [constants.EXT_CP, f.name, MPATH_CONF]
Line 171:         rc = misc.execCmd(cmd, sudo=True)[0]
Line 172:         if rc != 0:


-- 
To view, visit http://gerrit.ovirt.org/32363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I021c6f72eb5608cd61772d549eb13a229abb6c0d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list