Change in vdsm[master]: ppc: Over ppc arch vdsm reports UNKNOW as operationSystem i...

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Sep 4 06:28:21 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: ppc: Over ppc arch vdsm reports UNKNOW as  operationSystem in getVdsCaps
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/32444/1/vdsm/caps.py
File vdsm/caps.py:

Line 494:         return OSName.FEDORA
Line 495:     elif os.path.exists('/etc/redhat-release'):
Line 496:         return OSName.RHEL
Line 497:     elif os.path.exists('/etc/debian_version'):
Line 498:         return OSName.DEBIAN
needs to get here too
Line 499:     else:
Line 500:         return OSName.UNKNOWN
Line 501: 
Line 502: 


Line 512:             release = d.get('RELEASE', '')
Line 513:         elif osname == OSName.DEBIAN:
Line 514:             version = linecache.getline('/etc/debian_version', 1).strip("\n")
Line 515:             release = ""  # Debian just has a version entry
Line 516:         else:
perhaps replace the whole thing with platform.linux_distribution() ?
Line 517:             if platform.machine() == Architecture.PPC64:
Line 518:                 release_path = '/etc/ibm_powerkvm-release'
Line 519:             else:
Line 520:                 release_path = '/etc/redhat-release'


-- 
To view, visit http://gerrit.ovirt.org/32444
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e6ef83353b4b47a22d91d222ef1a0122b9470d3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list