Change in vdsm[ovirt-3.5]: vdsm-tool: changing root checking in configurator.

ybronhei at redhat.com ybronhei at redhat.com
Wed Sep 3 23:51:19 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vdsm-tool: changing root checking in configurator.
......................................................................


vdsm-tool: changing root checking in configurator.

Checking for root as we currently do in configure of libvirt and
sanlock is not enough. Currently this will fail during the
isConfigured() check since it does not have premissions to the
files it attempts to check:
"OSError: No such file or directory: /etc/libvirt/libvirtd.conf"

It is easy to see that this check is needed for all the exposed
methods of configurator. I'm suggesting to do it in the exposed
verbs in a uniform manner.

3.5 note: This commit broke master and it must be merged along
with change I8e86dd38e3a871d55ffc5cb67d5f4596ec4dc3a6.

Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136897
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31293
Reviewed-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32408
---
M lib/vdsm/tool/__init__.py
M lib/vdsm/tool/configurator.py
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/configurators/sanlock.py
4 files changed, 20 insertions(+), 7 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  mooli tayer: Verified



-- 
To view, visit http://gerrit.ovirt.org/32408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>


More information about the vdsm-patches mailing list