Change in vdsm[ovirt-3.5]: Live Merge: Return more info from _driveGetActualVolumeChain

danken at redhat.com danken at redhat.com
Wed Sep 3 20:06:35 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Live Merge: Return more info from _driveGetActualVolumeChain
......................................................................


Live Merge: Return more info from _driveGetActualVolumeChain

In followup patches, we want to return more information about each path
component from _driveGetActualVolumeChain.  We need the actual path as
given in the domain XML in order to properly update our metadata after
an active layer merge.  We also want to use this function to return high
write watermark information for block volumes.  This patch just converts
the format returned by _driveGetActualVolumeChain from a simple list to
a list of named tuples.

Change-Id: I01d142a68903048accc95eb04d9930c326965db0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1109920
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31364
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32319
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 12 insertions(+), 6 deletions(-)

Approvals:
  Adam Litke: Verified
  Federico Simoncelli: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/32319
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01d142a68903048accc95eb04d9930c326965db0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list